Add return type to createInitialState #460
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Signed-off-by: Valentin Lorentz <progval plus git at progval dot net> |
progval
force-pushed
the
type-initialevent
branch
from
cebbeee to
51c4df3
Compare
Half-Shot
reviewed
Mar 6, 2023
|
|
||
| export interface InitialEvent { | ||
| type: string, | ||
| content: Record<string, unknown>, |
Contributor
There was a problem hiding this comment.
Isn't this just MSC2346Content?
Author
There was a problem hiding this comment.
Ah yes sorry, I should have explained that. First, because callers need to cast it to a record of unknown anyway: https://github.com/matrix-org/matrix-appservice-irc/blob/3158cc521140ca6883e157ddb0bf01e96d455af4/src/provisioning/Provisioner.ts#L582
and also because I am working on adding support for MSC3968 and MSC3969, which will need genericity in the record type
This was referenced Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.